https://bugzilla.redhat.com/show_bug.cgi?id=2349757 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |mhroncok@xxxxxxxxxx Flags| |fedora-review+ CC| |mhroncok@xxxxxxxxxx --- Comment #3 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- spec file looks sane. rpmlint-reported issues seem fixed. Opinionated suggestion: Add -L to %pyproject_save_files (explicit is better than implicit). (Build)Requires looking good: $ rpm -qRp python-roman-numerals-py-3.1.0-1.fc43.src.rpm (python3dist(flit-core) < 4~~ with python3dist(flit-core) >= 3.7) (python3dist(tomli) if python3-devel < 3.11) pyproject-rpm-macros python3-devel python3-devel python3dist(packaging) python3dist(pip) >= 19 python3dist(pytest) >= 8 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(DynamicBuildRequires) <= 4.15.0-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(RichDependencies) <= 4.12.0-1 rpmlib(TildeInVersions) <= 4.10.0-1 $ rpm -qRp python3-roman-numerals-py-3.1.0-1.fc43.noarch.rpm python(abi) = 3.13 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 The license tag looks good and %check passes. APPROVED (if it still builds). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2349757 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202349757%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
