https://bugzilla.redhat.com/show_bug.cgi?id=2328685 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx CC| |decathorpe@xxxxxxxxx --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Package looks good to me. One minor thing and one general question: - Can you regenerate the spec with rust2rpm v27? It looks like you made no modifications on top of what's generated, so that should be easy, I hope :) - What are you packaging this crate for? It's ancient (last release in 2015, almost 10 years ago), and it raises a lot of compiler warnings on build. It's not a blocker for getting it reviewed, but whatever depends on this crate on might want to stop using it (or not) :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2328685 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202328685%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue