https://bugzilla.redhat.com/show_bug.cgi?id=2316282 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(zebob.m@xxxxxxxxx | |) | --- Comment #38 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- Ok my idea, since I have worked on it to, was to use this package as a drop-in replacement, since this is the same library. So provides exactly the same as the original one, that the user could dnf swap it. If you put the lib inside the main package it will conflict with the original libs package too and the swap won't be easy. What I would change: %bcond_with check -> %bcond check 1 to have consistent syntax. # cpuinfo is only available for %%{x86_64} %%{arm64} on Fedora -> # cpuinfo and libdovi are only availables for %%{x86_64} %%{arm64} on Fedora %if %{with libdovi} BuildRequires: libdovi-devel %endif -> %if %{with libdovi} BuildRequires: pkgconfig(dovi) %endif -> Prefer to use pkgconfig() and cmake() in your spec Something is wrong here: %if %{with unbundled_cpuinfo} BuildRequires: pkgconfig(libcpuinfo) Provides: bundled(cpuinfo) = 0^20201129gita7e1076-1 %endif if you unbundle, you should not have Provides: bundled(cpuinfo) at the same time: %if %{with unbundled_cpuinfo} BuildRequires: pkgconfig(libcpuinfo) %endif and %if %{without unbundled_cpuinfo} Provides: bundled(cpuinfo) = 0^20201129gita7e1076-1 %endif Regarding : Version: 2.3.0.B -> Version: 2.3.0~B with %global version_with_dash %(echo %{version} | tr '~' '-') and Source: %url/archive/v%{version_with_dash}/SVT-AV1-%{version_with_dash}.tar.gz But if you use forge : %global tag v%(echo %{version} | tr '~' '-') Regarding the conflicts, the guidelines are https://docs.fedoraproject.org/en-US/packaging-guidelines/Conflicts/#_library_name_conflicts which suggests: https://docs.fedoraproject.org/en-US/packaging-guidelines/EnvironmentModules/ and https://docs.fedoraproject.org/en-US/packaging-guidelines/Alternatives/ But Ihave not much experience with this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2316282 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202316282%23c38 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
