https://bugzilla.redhat.com/show_bug.cgi?id=2334903 Anthony Oon <anthony.zh.oon@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(benson_muite@emai | |lplus.org) --- Comment #34 from Anthony Oon <anthony.zh.oon@xxxxxxxxx> --- I missed covering this feedback. (In reply to Benson Muite from comment #2) > Initial comments: > a) Try to use packaged fonts rather than bundling fonts. Go through the > installation process, remove the > installed fonts and place symlinks to the system fonts. To clarify, the srpm contains bundled fonts as ghostty compiles its fallback fonts (JetBrains Mono Nerd Font, Symbols) into the binary, additional fonts are also used only for testing and are not installed. > b) The zig build system has options to use system libraries where possible. > Does this work for the non Zig > libraries? Using system libraries requires writing the build script configuration switches to switch between a build.zig.zon source dependency or a system integrated dependency. Pull requests can be made to configure more dependencies for system integration. > c) Are any of the Zig libraries relatively stable and worth packaging? The current zig dependency system (not system integrated) is that it expects an archive or directory with a matching contents hash as specified in the build.zig.zon file. Then "zig fetch <directory/archive>" is performed before building to populate a zig-cache-dir with "zig-cache-dir/p/<contents-hash>". At build-time the existence of the "cache/p/<hash>" is checked against the build.zig.zon specification. As for stable packages, I'm not confident that the current zig dependency system is stable. Currently, each dependency in a build.zig.zon is not tagged with a version as it's only a URL + contents-hash, a version can only be inferred from the url. There's several open issues for the build system set aside for future milestones https://github.com/ziglang/zig/milestones. We can also expect churn for existing zig projects with breaking language changes between compiler releases at least until a 1.0.0 compiler -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2334903 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202334903%23c34 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
