https://bugzilla.redhat.com/show_bug.cgi?id=2338412 --- Comment #36 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- Based on the list of sources included in the debugsource RPM, here's what the License: field should look like: License: Zlib AND (NTP AND Zlib) AND Unlicense AND MIT AND (MIT OR Unlicense) AND LicenseRef-Fedora-Public-Domain Breakdown: ./examples/showanim.c: Zlib ./examples/showimage.c: Zlib ./include/SDL3_image/SDL_image.h: Zlib ./src/IMG_avif.c: Zlib ./src/IMG_bmp.c: Zlib ./src/IMG.c: Zlib ./src/IMG_gif.c: NTP AND Zlib ./src/IMG_jpg.c: Zlib ./src/IMG_jxl.c: Zlib ./src/IMG_lbm.c: Zlib ./src/IMG_pcx.c: Zlib ./src/IMG_png.c: Zlib ./src/IMG_pnm.c: Zlib ./src/IMG_qoi.c: Zlib ./src/IMG_stb.c: Zlib ./src/IMG_svg.c: Zlib ./src/IMG_tga.c: Zlib ./src/IMG_tif.c: Zlib ./src/IMG_webp.c: Zlib ./src/IMG_WIC.c: Zlib ./src/IMG_xcf.c: Zlib ./src/IMG_xpm.c: Zlib ./src/IMG_xv.c: Zlib ./src/miniz.h: Unlicense ./src/nanosvg.h: Zlib ./src/nanosvgrast.h: Zlib ./src/qoi.h: MIT ./src/stb_image.h: MIT OR Unlicense ./src/tiny_jpeg.h: Public Domain However, taking a closer look at: ./src/IMG_gif.c: NTP AND Zlib I found something concerning. The "NTP" license header comes from Xpaint source code and it's not exactly NTP. https://github.com/libsdl-org/SDL_image/blob/main/src/IMG_gif.c#L28C1-L38C76 /* Code from here to end of file has been adapted from XPaint: */ /* +-------------------------------------------------------------------+ */ /* | Copyright 1990, 1991, 1993 David Koblas. | */ /* | Copyright 1996 Torsten Martinsen. | */ /* | Permission to use, copy, modify, and distribute this software | */ /* | and its documentation for any purpose and without fee is hereby | */ /* | granted, provided that the above copyright notice appear in all | */ /* | copies and that both that copyright notice and this permission | */ /* | notice appear in supporting documentation. This software is | */ /* | provided "as is" without express or implied warranty. | */ /* +-------------------------------------------------------------------+ */ The original NTP license (https://spdx.org/licenses/NTP.html) reads: Copyright (c) (CopyrightHoldersName) (From 4-digit-year)-(To 4-digit-year) Permission to use, copy, modify, and distribute this software and its documentation for any purpose with or without fee is hereby granted, provided that the above copyright notice appears in all copies and that both the copyright notice and this permission notice appear in supporting documentation, and that the name (TrademarkedName) not be used in advertising or publicity pertaining to distribution of the software without specific, written prior permission. (TrademarkedName) makes no representations about the suitability of this software for any purpose. It is provided "as is" without express or implied warranty. Notice the lack of "with or" before "without fee" in Xpaint-derived code. I think we need some expert review if this is substantially different from the original NTP to constitute a new license and if it's allowed in Fedora. If I understand correctly, the authors of that code did not give explicit permission to distribute it for a fee. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2338412 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202338412%23c36 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
