Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: checkgmail - System Tray Application that checks a Gmail Account for New Mai https://bugzilla.redhat.com/show_bug.cgi?id=432152 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From panemade@xxxxxxxxx 2008-02-09 01:19 EST ------- 1)Source url should be http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.bz2 2) Good if you either use macros for all commands in SPEC like for rm also or drop macro use for commands to install -Dpm 0755 checkgmail $RPM_BUILD_ROOT%{_bindir}/checkgmail gzip -d man/checkgmail.1.gz install -Dpm 0644 man/checkgmail.1 $RPM_BUILD_ROOT%{_mandir}/man1/checkgmail.1 3) Good if you download source like and submit new SRPM wget http://downloads.sourceforge.net/checkgmail/checkgmail-1.13.tar.bz2 this will preserve upstream tarball release timestamp. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review