https://bugzilla.redhat.com/show_bug.cgi?id=2346531 Petr Lautrbach <plautrba@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(plautrba@redhat.c | |om) | Status|NEW |ASSIGNED --- Comment #3 from Petr Lautrbach <plautrba@xxxxxxxxxx> --- (In reply to Vit Mojzis from comment #2) > ===== MUST items ===== > [!] selinux-policy-epel.spec:123 should probably use > %{_datadir}/selinux/mls/epel-modules.lst instead of > %{_datadir}/selinux/targeted/epel-modules.lst > Running scriptlet: selinux-policy-epel-mls-40.13.26-1.el10.noarch > 4/5 > sed: can't read /usr/share/selinux/targeted/epel-modules.lst: No such > file or directory > semodule: option requires an argument -- 'i' > usage: semodule [option]... MODE... @@ -116,7 +117,7 @@ fi %selinux_relabel_pre -s mls %post mls -sed 's#^\(.*\)$#%{_datadir}/selinux/mls/\1.pp#' %{_datadir}/selinux/targeted/epel-modules.lst | xargs semodule -n -s mls -X 200 -i || : +sed 's#^\(.*\)$#%{_datadir}/selinux/mls/\1.pp#' %{_datadir}/selinux/mls/epel-modules.lst | xargs semodule -n -s mls -X 200 -i || : selinuxenabled && load_policy || : %posttrans mls > [!]: License file installed when any subpackage combination is installed. > selinux-policy-epel-devel has no dependencies and does not contain a > license file - it should probably require selinux-policy-epel > selinux-policy-epel-targeted and selinux-policy-epel-mls require > selinux-policy-targeted and selinux-policy-mls respectively, which > both require selinux-policy, which installs the same license file as > selinux-policy-epel (not sure it they should also require > selinux-policy-epel) @@ -37,6 +37,7 @@ Requires: selinux-policy-mls %package devel Summary: SELinux targeted policy for EPEL packages - header files +Requires: selinux-policy-devel %description devel > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/selinux, > /usr/share/selinux/devel, /var/lib/selinux/mls/active/modules/200, > /var/lib/selinux/targeted/active/modules/200 > /usr/share/selinux and /usr/share/selinux/devel are owned by > selinux-policy, which should be required by selinux-policy-epel-devel @@ -135,10 +136,12 @@ fi %license targeted/COPYING %files targeted -f %{_builddir}/targeted-epelmodules.lst +%dir %{_sharedstatedir}/selinux/active/active/200 %{_datadir}/selinux/targeted/epel-modules.lst %{_datadir}/selinux/targeted/*.pp %files mls -f %{_builddir}/mls-epelmodules.lst +%dir %{_sharedstatedir}/selinux/mls/active/200 %{_datadir}/selinux/mls/epel-modules.lst %{_datadir}/selinux/mls/*.pp > [!]: Requires correct, justified where necessary. > selinux-policy-epel-devel should require selinux-policy-epel @@ -37,6 +37,7 @@ Requires: selinux-policy-mls %package devel Summary: SELinux targeted policy for EPEL packages - header files +Requires: selinux-policy-devel %description devel > [!]: Package installs properly. > selinux-policy-epel-mls fails without selinux-policy-epel-targeted (typo > noted above) see above > [!]: Spec use %global instead of %define unless justified. > Note: %define requiring justification: %define makeConf() %make_build > -C %1 %common_params UNK_PERMS=%3 NAME=%1 TYPE=%2 bare %make_build -C > %1 %common_params UNK_PERMS=%3 NAME=%1 TYPE=%2 conf install -p -m0644 > ./%1/dist/%1/booleans.conf ./%1/policy/booleans.conf install -p -m0644 > ./%1/dist/%1/users ./%1/policy/users # install -p -m0644 > ./%1/dist/%1/modules.conf ./%1/policy/modules.conf %{SOURCE3} > %{SOURCE2} ./%1/dist/%1/modules.conf enabled > > ./%1/policy/modules.conf, %define makeModules() %make_build -C %1 > %common_params UNK_PERMS=%3 NAME=%1 TYPE=%2 base.pp %make_build -C %1 > %common_params UNK_PERMS=%3 NAME=%1 TYPE=%2 modules, %define > makeInstall() %make_build -C %1 %common_params UNK_PERMS=%3 NAME=%1 > TYPE=%2 DESTDIR=%{buildroot} install %define is used for a local macros inside local contexts > Generic: > [!]: Spec file according to URL is the same as in SRPM. > Note: Spec file as given by url is not the same as in SRPM (see > attached diff). > [x]: Rpmlint is run on all installed packages. > Note: There are rpmlint messages (see attachment). updated: Spec URL: https://fedorapeople.org/~plautrba/selinux-policy-epel/selinux-policy-epel.spec SRPM URL: https://fedorapeople.org/~plautrba/selinux-policy-epel/selinux-policy-epel-40.13.26-1.fc43.src.rpm Description: SELinux policy for EPEL packages Fedora Account System Username: plautrba -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2346531 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202346531%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
