https://bugzilla.redhat.com/show_bug.cgi?id=2333125 --- Comment #15 from Christoph Junghans <junghans@xxxxxxxxx> --- > a) Can the hidden files be removed? Sphinx can also generate man pages which > might be easier to package. Hidden files removed, I ran fdupes to remove the duplicated files. I didn't look into manpages, I will leave that to upstream. > b) If stb is to be bundled, its license must be indicated. From: > https://src.fedoraproject.org/rpms/stb/blob/rawhide/f/stb.spec > https://github.com/nothings/stb > it is under MIT or Unlicense. > Please also add: > Provides: Bundled(stb) = <version> > see: > https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling stb_include.h is only used to provide an undocumented option (USE_AMALGAMATED), which wasn't even used at all, so I patched it out without any functionality loss. Patch sent upstream as well. However, the package also uses stb_arr in a test, which got deprecated in stb a while ago, so I added a Provides: for that. An issue was filed with upstream, but as it is only used in the tests, I don't think that is big deal. Fedora users won't ever see that part. > c) Perhaps alert upstream on some of the issues with stb_include mentioned > at: > https://src.fedoraproject.org/rpms/stb/blob/rawhide/f/stb.spec#_4 > and check if they still want to use it as is. Patch out, see above. Spec URL: https://junghans.fedorapeople.org/ALL.spec SRPM URL: https://junghans.fedorapeople.org/ALL-0.9.3-4.fc43.src.rpm TaskID: https://koji.fedoraproject.org/koji/taskinfo?taskID=129560543 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2333125 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202333125%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
