https://bugzilla.redhat.com/show_bug.cgi?id=2347045 --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > %{-i:Source: %{appid}.appdata.xml}\ This is too close to conditional sources for my liking. We don't allow sources to be conditional in a spec file, they need to be unconditionally included in the SRPM. Please pull this out and use regular Source lines. > %define app_subpkg(n:i:) \ Wouldn't this make sense as an RPM macro that is used in the actual utility and library packages? > Supplements: (%{pkgname} and flatpak-runtime-config)\ Does this work in the flatpak build environment? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2347045 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202347045%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
