https://bugzilla.redhat.com/show_bug.cgi?id=2346613 --- Comment #3 from Michal Konecny <mkonecny@xxxxxxxxxx> --- (In reply to Miro Hrončok from comment #1) > Why do you use `%pyproject_buildrequires -t` when you are not using %tox? Probably copied from another spec file for different python package. (In reply to Miro Hrončok from comment #2) > Is there a reason to hardcode the source URL instead of using %{pypi_source > datanommer_commands}? > > Why there is %modname defined to datanommer_commands when the "module name" > is in fact datanommer.commands an this macro is only used in %prep to name a > directory? Woudl you consider not defining this macro for a single usage? I tried to use %{pypi_source datanommer_commands}, but it failed with 404. Let me try it again. I will probably change the macro, as it isn't really used with the datanommer-commands, datanommer.commands and datanommer_commands mess. I will update the spec file according to your comments. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2346613 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202346613%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
