https://bugzilla.redhat.com/show_bug.cgi?id=2332598 --- Comment #6 from wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> --- (In reply to Fabio Valentini from comment #5) > (In reply to wojnilowicz from comment #4) > > Looks good to me except > > -license = "MIT/Apache-2.0" > > +license = "(MIT OR Apache-2.0) AND MIT" > > Did you add "AND MIT" due to the following files: > > 1) https://github.com/mattico/elasticlunr-rs/blob/master/LICENSE-JS > > 2) https://github.com/mattico/elasticlunr-rs/blob/master/LICENSE-WORDS > > ? > > Yes, the README explicitly states that parts of the project are covered by > different (i.e. only MIT) license: > > > Includes code ported from [elasticlunr.js][eljs] Copyright (C) 2017 by Wei Song, > > used under license. See LICENSE-JS for details. > > > > Includes stop word lists ported from [stopwords-filter][swft] Copyright (C) 2012 > > David J. Brenes, used under license. See LICENSE-WORDS for details. Shouldn't that be reflected at this line https://github.com/mattico/elasticlunr-rs/blob/master/Cargo.toml#L3 ? I mean shouldn't the following line license = "MIT/Apache-2.0" change to license = "(MIT OR Apache-2.0) AND MIT" to firstly remove ambiguity of the deprecated "/" char, and secondly truly reflect what the licensing terms are? Details at https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields Do you plan any PR for that? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2332598 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202332598%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
