[Bug 2300113] Review Request: bign-handheld-thumbnailer - A thumbnailer for Nintendo handheld systems (Nintendo DS and 3DS) roms and files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2300113

Mateus Rodrigues Costa <mateusrodcosta@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(mateusrodcosta@gm |
                   |ail.com)                    |



--- Comment #9 from Mateus Rodrigues Costa <mateusrodcosta@xxxxxxxxx> ---
> rpmlint gives error both on rpm file (see review text above).

So, about those messages:

```
bign-handheld-thumbnailer.src: E: spelling-error ('roms', '%description -l
en_US roms -> toms, rims, oms')
bign-handheld-thumbnailer.x86_64: E: spelling-error ('roms', '%description -l
en_US roms -> toms, rims, oms')
bign-handheld-thumbnailer.x86_64: W: no-manual-page-for-binary
bign-handheld-thumbnailer
 2 packages and 0 specfiles checked; 2 errors, 1 warnings, 7 filtered, 2
badness; has taken 0.3 s 
```

"roms" is a valid word, specially when related to videogames, which is the
context here (i.e. "game roms"). So that message can be safely ignored.
And, yes, I didn't put the effort yet to create a man page. Since it's just a
thumbaniler there might not be as much benefit in having a man page, but I
still plan on trying to create one in the future.

> Looks good, but I am running into issues with debuginfo package. 

So, about

```
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe1 in position 443:
invalid continuation byte
```

I asked on the Fedora Rust SIG Matrix room and they basically said:

> 🤷 Don't think it's an important check, particularly on a debuginfo package.

They did worrry a bit that since I am using meson and meson macros, the correct
Rust build flags are being set.

---

IMHO those warning are not important, but you can always ping some Rust
packager to confirm.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2300113

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202300113%23c9

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux