https://bugzilla.redhat.com/show_bug.cgi?id=2345173 Jonathon Hyde <siliconwaffle@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |siliconwaffle@trilbyproject | |.org --- Comment #8 from Jonathon Hyde <siliconwaffle@xxxxxxxxxxxxxxxxx> --- So your updated specfile looks good, just a small suggestion that could improve it some: under %files you could change %{_mandir}/man1/%{name}.1p.gz to %{_mandir}/man1/%{name}.1*. This is to comply with the packaging guidelines here: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages. And the reason this is here is because rpmbuild will re-compress manpages to whatever it's preferred format is, which could vary depending on the distribution and/or configuration. I'm also not sure that %{_fixperms} is necessary, I thought mock already executed that command automatically but perhaps I'm remembering wrong. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2345173 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202345173%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
