https://bugzilla.redhat.com/show_bug.cgi?id=2345173 Lukas Javorsky <ljavorsk@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ndavidov@redhat.c | |om) --- Comment #5 from Lukas Javorsky <ljavorsk@xxxxxxxxxx> --- Specfile tips: 1. Please make use of the `%autosetup` macro if possible (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_autosetup) 2. Make use of the %{name} macro where you can. It eliminates the TYPOs 3. I'm unsure if the `rpmautospec` does this in COPR or if the SPEC file is the same as the one in your local directory. Could you please load it somewhere else so I can see if COPR causes it? 4. As we've discussed previously, it's a good practice to link the upstream proposal for the patch next to our downstream patches. Please update your spec, upload it, and link it here in the new comment so I can see the new fixed version. After that I'll move to the review process. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2345173 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202345173%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
