Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fox - A C++ library for GUI development https://bugzilla.redhat.com/show_bug.cgi?id=431665 ------- Additional Comments From pertusus@xxxxxxx 2008-02-08 05:17 EST ------- There are dots missing at the end of %descriptions. The files in %_bindir also share a common namespace, so in there too they should be fox-PathFinder and fox-calculator. (and corresponding man pages). Adie.stx looks like a config files. It should be in %_datadir, and it should be possible to override it with a file in %_sysconfdir and a file in $HOME/.something. fox-config should be a wrapper around pkg-config calls to avoid multilib conflicts. the pkgconfig file for fox is wrong. There is certainly no need to link against all those libs to link against fox. Libs: should only contain link flags for libraries that will be used directly by applications linking against fox. Libs.static: should contain link flags for the remaining libraries linked against the fox library (but not needed directly by applications linking against the fox library). You can have an idea about that by doing ldd -u -r /usr/bin/adie it will show all the overlinking in that example. Looking at the fox headers, it seems to me that fox completly hides the underlying X/GL and image libs, so that Libs should only be: Libs: -L${libdir} ${FOX_LIBS} Regarding the include files there are very strange things, namely there are autoconf conditionals in headers, like in fx3d.h #ifdef HAVE_GLU_H This is not right, these conditionals should be in .cpp files, not in the API. The file xincs.h is especially full of these, and also full of include files for other APIs. However it doesn't seems to be included in any other file, so it may certainly be dropped completely from the fox API. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review