https://bugzilla.redhat.com/show_bug.cgi?id=2333125 --- Comment #6 from Christoph Junghans <junghans@xxxxxxxxx> --- > Comments: > a) Maybe good to generate the binary data files. They probably do not need > to be stored in the repo or the distributed source tarball. That is an upstream decision, I can ask them to make a special tarball for us, but as their tarball is only 24MB and those files aren'y getting installed, I don't think it is worth the time. Plus one needs to store the gold standard files to compare against somewhere. > b) Can the contrib directory be removed in the prep stage to ensure Fedora > packaged dependencies are used? In particular stb is in Fedora: > https://packages.fedoraproject.org/pkgs/stb/stb-devel/ I tried that, but our stb-devel does include stb_include.h, which is used here. I removed contrib/voro++ though. > c) Can the documentation be built? I tried that, too, I could get the documentation build to work, I think it is broken for out-of-source builds. > d) Is it possible to ensure that /usr/lib64/mpich/lib/make and > /usr/lib64/openmpi/lib/make are owned. Done. Spec URL: https://junghans.fedorapeople.org/ALL.spec SRPM URL: https://junghans.fedorapeople.org/ALL-0.9.3-2.fc43.src.rpm TaskID: https://koji.fedoraproject.org/koji/taskinfo?taskID=128950330 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2333125 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202333125%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
