Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: thaifonts-scalable - Thai TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=431829 ------- Additional Comments From petersen@xxxxxxxxxx 2008-02-07 23:37 EST ------- Thanks for the review. :) > thaifonts-scalable.noarch: W: conffile-without-noreplace-flag > /etc/fonts/conf.avail/90-ttf-thai-tlwg-synthetic.conf I think conf.avail files do not need to be noreplace: they can be copied and edited in conf.d if necessary. > SHOULD: > 1) you can write only rm also instead to write /bin/rm > 2) your make install command should be > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" Thanks, I will fix those before importing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review