https://bugzilla.redhat.com/show_bug.cgi?id=2343235 --- Comment #8 from Man2Dev@xxxxxxxxx --- > ===== Issues ===== > > - The line > > %bcond tests 0 > > is missing. Add that line so that you can do e.g.: > > fedpkg mockbuild --with tests > > For more documentation on build conditionals, see: > > > https://rpm-software-management.github.io/rpm/manual/conditionalbuilds.html > > Since an “undefined” build conditional has the same effect as one that is > set > false, the package still builds correctly, and this issue doesn’t block > approval. > > - I think it would be better to remove these: > > BuildRequires: shellcheck > BuildRequires: devscripts > > and these: > > shellcheck %{buildroot}%{_bindir}/wcurl ./tests/* > checkbashisms %{buildroot}%{_bindir}/wcurl ./tests/* > > While these are tests that you *could* run, they fall under the category of > linters, style-checkers, etc., that check code quality rather than > functionality. There is no general guideline against running linting tests > (and so you are not *required* to change anything here), but the Python > guidelines make a pretty good general case against them in > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters. > “Linters are “often ‘opinionated’ and their ‘opinions’ change frequently > enough that they are nuisance in Fedora, where the linter is not pinned to > an > exact version.” > > ===== Notes ===== > > - This is not wrong: > > %autosetup -n %{name}-%{version} > > but it just reiterates the default. This would be simpler and equivalent: > > %autosetup > notes have been applied:) # https://src.fedoraproject.org/rpms/wcurl Spec URL: https://download.copr.fedorainfracloud.org/results/man2dev/wcurl/srpm-builds/08598633/wcurl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/man2dev/wcurl/srpm-builds/08598633/wcurl-2024.12.08-1.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2343235 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202343235%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
