https://bugzilla.redhat.com/show_bug.cgi?id=2343404 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: Dolibarr - |Review Request: Dolibarr - |file PHP |ERP and CRM software for | |small and medium companies | |or foundations CC| |code@xxxxxxxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Fixed the summary in the bug title to match the one in the submitted spec file. You must submit the source RPM, not the “built” binary RPM. I’m not planning to take this review, but overall, at a glance, I see a lot of obsolete and/or specifically prohibited boilerplate in the spec file, and it’s going to be time-consuming for a reviewer to wade through all of that. I know that Fedora’s packaging guidelines, https://docs.fedoraproject.org/en-US/packaging-guidelines/, are a large document, but I think it would wise to spend some time studying the relevant sections and making an attempt to conform to current practices. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2343404 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202343404%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue