https://bugzilla.redhat.com/show_bug.cgi?id=2264773 --- Comment #9 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Thank you for the review! Upstream is going to be excited to finally have this in Fedora. > a) Running > gram_grep --help > is a reasonable smoke test. Some of the examples could also be used: > http://benhanson.net/gram_grep.html That’s a good idea. I’ll add some straightforward examples from that page as smoke tests in a %check section. > d) Review of https://bugzilla.redhat.com/show_bug.cgi?id=2334976 would be appreciated if time allows. I have taken the review, although it may be a few days before I have time to complete it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2264773 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202264773%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue