https://bugzilla.redhat.com/show_bug.cgi?id=2323073 --- Comment #10 from Sandro <gui1ty@xxxxxxxxxxxxx> --- Thanks for the review. I have updated the package to the latest release, added the option to pytest to show the reason for skipping a test. I also enabled the tests requiring xvfbwrapper. Unfortunately that requires specifying xorg-x11-server-Xvfb separately. I believe that should be a dependency pulled in by python3-xvfbwrapper. I'll submit a PR. Regarding xvfb-run vs. xwfbrun, I'll cross that bridge when we get there. Since xvfbwrapper appears to be a test dependency only, I don't think it makes sense to package the extra. I'll consider it if another package comes along requiring nipype[xvfbwrapper], which I think is unlikely. Last but not least I added a recommends for dcm2niix. Thanks for pointing that out. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2323073 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202323073%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
