https://bugzilla.redhat.com/show_bug.cgi?id=2343235 --- Comment #2 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- A few quick preliminary findings before I go through the whole fedora-review template. ---- You have (accidentally, I think) put everything into a subpackage called wcurl-wcurl. Try omitting %package %{name} Summary: %{summary} %description %{name} %{_description} and changing %files %{name} to %files so that everything is associated with the base wcurl package. ---- The package doesn’t actually contain /usr/bin/wcurl. Upstream doesn’t have a build system (since this is just a shell-script wrapper around curl), but you still have to install something. Also, man pages need to be installed in a standard location, not as generic documentation; see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages. Try this: %install install -t '%{buildroot}%{_bindir}' -D -p wcurl install -t '%{buildroot}%{_mandir}/man1' -D -m 0644 -p wcurl.1 Remove this from %files: %doc %{name}.1 …and add these: %{_bindir}/wcurl %{_mandir}/man1/wcurl.1* ---- You don’t need these: BuildRequires: bash Requires: bash The shell script actually has #!/bin/sh so it just requires a POSIX shell, not bash in particular. You can rely on that (and, indeed, bash itself) being present in the buildroot, and once you actually install the script properly in /usr/bin, you’ll find that the dependency on /usr/bin/sh is automatically generated based on the shebang line. ---- Arguably, AUTHORS would be better considered as an additional LICENSE file (%license) rather than a generic documentation file (%doc), since it’s referenced from the copyright statement in the LICENSE file text. ---- Please do not include an Epoch tag in a new package! Use these only when absolutely necessary. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_epoch_tag ---- You don’t have to number the sole Source; you can write "Source:" instead of "Source0:". The exception is if you plan to build this for EPEL8 from the same spec file. ---- The description starts with a lower-case letter, which looks like an accident, and unnecessarily repeats the summary. Consider dropping the %_description macro (since you aren’t going to have any subpackages with repeated descriptions) and just writing this: %description %{summary}. ---- The License needs to be a valid SPDX expression. Write "curl", not "Curl". See https://spdx.org/licenses/curl.html and https://docs.fedoraproject.org/en-US/legal/allowed-licenses/. ---- This is not wrong: %autosetup -p1 -n %{name}-%{version} …but -n %{name}-%{version} is the default, so you can omit it. ---- Upstream includes tests that don’t require network access, and you should be able run them, except that the shunit2 package in Fedora is too old. I filed bug 2343252 and opened https://src.fedoraproject.org/rpms/shunit2/pull-request/1, but for now Still, you can add: # Requires shunit2 2.1.8, but we have 2.1.6. # https://bugzilla.redhat.com/show_bug.cgi?id=2343252 %bcond tests 0 and %if %{with tests} BuildRequires: shunit2 %endif and in %check: %if %{with tests} PATH="${PATH}:%{buildroot}%{_bindir}" ./tests/tests.sh %endif and then (I confirmed by testing) you will be ready to run the tests later, if and when my PR is merged, plus you will have documented why you are not doing so now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2343235 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202343235%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
