[Bug 2339019] Review Request: php-splitbrain-lesserphp - PHP library for compiling LESS stylesheets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2339019



--- Comment #7 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> ---
Using dnf repoquery shows that the only package depending on
php-marcusschwarz-lesserphp is dokuwiki,
which will be dropping the dependency once I finally update it to a newer
version.
As such, I've removed the Obsoletes completely.

> Note: Directories without known owners: /usr/share/php/splitbrain
Fixed.

>     Requires: php-cli >= 7.4.0
> Please use php(language) >= 7.4.0, see https://docs.fedoraproject.org/en-US/packaging-guidelines/PHP/#requires-provides-min-php
>     Requires: php-date
>     Requires: php-pcre
> Both can be removed, see https://docs.fedoraproject.org/en-US/packaging-guidelines/PHP/#requires-provides-extensions
Done.

> About composer.json stuff
> 1/ you have both a sed command and a patch, why ?
I guess I tried sed first, then went for the patch and forgot to remove the sed
call.
> 2/ better fix
Thanks!

spec:
https://suve.fedorapeople.org/review/php-splitbrain-lesserphp-0.10.2-2/php-splitbrain-lesserphp.spec
srpm:
https://suve.fedorapeople.org/review/php-splitbrain-lesserphp-0.10.2-2/php-splitbrain-lesserphp-0.10.2-2.fc41.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=128656084


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2339019

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202339019%23c7

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux