https://bugzilla.redhat.com/show_bug.cgi?id=2338639 --- Comment #5 from Cole Robinson <crobinso@xxxxxxxxxx> --- (In reply to Hanna Czenczek from comment #4) > > I’m not sure I follow. I did use rust2rpm, but actually without any config > file (just `rust2rpm -t fedora -o spec imago`). That is to say, the > rust2rpm.toml would currently be empty. > > > the manual dep tweaks should be described in a comment. > > It’s not a manual tweak, it’s been auto-generated by rust2rpm. Adding such > a `package.cargo-toml-patch-comments` section to rust2rpm.toml makes it > complain that “Cargo.toml was not patched” (the Cargo.toml it wants me to > modify already has the Windows section removed as per that auto-generated > patch). Ah, I did not realize rust2rpm autogenerated a patch sometimes! I should have looked closer at the spec comment. I thought that patch came from `rust2rpm --patch`. So I've learned something new :) Indeed I see `rust2rpm -t fedora -o spec imago` generates spec identical to yours. So I'll do full review now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2338639 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202338639%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
