https://bugzilla.redhat.com/show_bug.cgi?id=2338639 Cole Robinson <crobinso@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) | CC| |crobinso@xxxxxxxxxx Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |crobinso@xxxxxxxxxx Flags| |fedora-review? | |needinfo?(hreitz@xxxxxxxxxx | |) --- Comment #3 from Cole Robinson <crobinso@xxxxxxxxxx> --- I'll take this, and I can sponsor you too. src.rpm link is broken too but I found spec and src.rpm here: https://download.copr.fedorainfracloud.org/results/hczenczek/rust-imago/fedora-rawhide-x86_64/08512753-rust-imago/ nothing here looks surprising but I didn't do a deep dive yet. couple bits up front: can you convert this package to use rust2rpm.toml, and post the contents of that file? this rust crates easier to review: I can manually regenerate the package to make sure nothing weird is going on. makes it easier to maintain in dist-git too. the manual dep tweaks should be described in a comment. rust2rpm.toml has support for this, see cargo-toml-patch-comments example here: https://bugzilla.redhat.com/show_bug.cgi?id=2326979#c14 (In reply to Hanna Czenczek from comment #1) > Note a potential ix86 issue: The vm-memory feature package > (rust-imago+vm-memory-devel) depends on rust-vm-memory-devel, which is not > available for ix86. As far as I understand, I don’t need to explicitly > exclude ix86 in this package, though, right? > > (FWIW, this package can be built successfully for i386: > https://copr.fedorainfracloud.org/coprs/hczenczek/rust-imago/build/8512815/) AFAIK if it builds, it's fine :) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2338639 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202338639%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
