https://bugzilla.redhat.com/show_bug.cgi?id=2339019 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/php/splitbrain [!]: If the package is a rename of another package, proper Obsoletes and Provides are present. php-splitbrain-lesserphp.noarch: W: obsolete-not-provided php-lessphp Don't obsolete it or provide it if it is fully compatible but in this case, you also have to package the old autoloader (a link to the new one ?) [!]: Requires correct, justified where necessary. Requires: php-cli >= 7.4.0 Please use php(language) >= 7.4.0, see https://docs.fedoraproject.org/en-US/packaging-guidelines/PHP/#requires-provides-min-php Requires: php-date Requires: php-pcre Both can be removed, see https://docs.fedoraproject.org/en-US/packaging-guidelines/PHP/#requires-provides-extensions About composer.json stuff 1/ you have both a sed command and a patch, why ? 2/ better fix is to move "tests" in "autoload-dev", which can be submitted to upstream: "autoload": { "psr-4": { "LesserPHP\\": "src" } }, "autoload-dev": { "psr-4": { "LesserPHP\\tests\\": "tests" } }, 3/ alternative use "phpab --template fedora --output src/autoload.php src" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2339019 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202339019%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
