https://bugzilla.redhat.com/show_bug.cgi?id=2335285 --- Comment #21 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thanks, the package looks pretty good to me now! Two things I'd like to have fixed before I approve the package: 1) The indentation of "Tag: Value" lines is inconsistent. Looks like most are indented by 15 characters instead of 16, I assume this is unintentional. 2) I would recommend to add a comment to the spec file saying that the full break-down of the licenses that make up the License tag is documented in the LICENSE.dependencies file in the package. This is technically required by the Packaging Guidelines. In general, I recommend keeping the output of %cargo_license_summary from the build.log as a comment above the resulting "License" tag to make diffing for new versions easier. It might also be good to add a comment to the effect of "the Rust implementation in rust/ is Apache-2.0 licensed, other code covered by different licenses is neither used nor shipped in built packages". There's another thing that would be "nice to have" before importing the package, but not a "must have": Upstream has released a new version last week, 4.28.0. Updating to the latest version before I approve this review is not required, but it would be great if you could check if bumping from 4.27.0 to 4.28.0 would be easy or not. The diff v4.27.0...v4.28.0 restricted to rust/ folder looks like there are compatibility fixes for newer Firefox versions, so that might be "nice to have". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2335285 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202335285%23c21 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
