Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: binutils https://bugzilla.redhat.com/show_bug.cgi?id=225615 ------- Additional Comments From limb@xxxxxxxxxxxx 2008-02-07 08:13 EST ------- (In reply to comment #2) > I think it would be better to change the perl substitution > to a sed substitution. I concur. > the gzipping of info files will be done automatically, > and install-info knows how to install/remove compressed info files. Cool, I didn't know that. > I suggest using > %defattr(-,root,root,-) instead of %defattr(-,root,root) What would the advantage be? Just curious. > Why not use %configure and why use %makeinstall? Looks like > DESTDIR is rightly used. Have the concerns from the changelog on line 885 been addressed? I've never had a problem with %configure myself. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review