https://bugzilla.redhat.com/show_bug.cgi?id=2335285 --- Comment #14 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thanks for the update! More notes: 8. I took another look at the "remove-unsupported-function" patch, and it's not entirely correct. > let _ = untargz(compressed_file, target, log); > Ok(()) This means "do untargz()" and discard any errors. Replacing those two lines with this one line should work, and propagate errors (as is done in the original code): """ untargz(compressed_file, target, log)? """ ============================================================ Regarding the other issues raised previously: 1. ✅ 2. ✅ 3. ✅ 4. was not applied, summary still repeats the package name Additionally, the %description doesn't sound accurate. Is that taken from "selenium" in general? Maybe taking some inspiration from the rust/README.md file would be more appropriate for %descruption: """ %description Selenium Manager is a command-line tool implemented in Rust that provides automated driver and browser management for Selenium. """ 5. ✅ 6. ✅ 7. The license tag was not adapted correctly. The list of licenses printed during the build are: # (MIT OR Apache-2.0) AND Unicode-DFS-2016 # 0BSD OR MIT OR Apache-2.0 # Apache-2.0 # Apache-2.0 OR BSL-1.0 # Apache-2.0 OR ISC OR MIT # Apache-2.0 OR MIT # Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT # BSD-3-Clause # ISC # ISC AND MIT AND OpenSSL # MIT # MIT OR Apache-2.0 # MIT OR Apache-2.0 OR Zlib # MIT OR Zlib OR Apache-2.0 # MPL-2.0 # Unlicense OR MIT # Zlib OR Apache-2.0 OR MIT I would recommend to paste this into the spec file for reference, this is common practice for Rust packages. The resulting License tag would be: """ License: Apache-2.0 AND BSD-3-Clause AND ISC AND MIT AND OpenSSL AND MPL-2.0 AND Unicode-DFS-2016 AND (0BSD OR MIT OR Apache-2.0) AND (Apache-2.0 OR BSL-1.0) AND (Apache-2.0 OR ISC OR MIT) AND (Apache-2.0 OR MIT) AND (Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT) AND (MIT OR Apache-2.0 OR Zlib) AND (Unlicense OR MIT) """ This string validates successfully using "license-validate <expression>". see here for an example how almost all Rust packages handle this: https://src.fedoraproject.org/rpms/rust-ripgrep/blob/rawhide/f/rust-ripgrep.spec#_28-35 or, if you would like to keep this better diffable and more readable, you can use the %shrink macro, like here: https://src.fedoraproject.org/rpms/python-orjson/blob/rawhide/f/python-orjson.spec#_53-60 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2335285 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202335285%23c14 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
