https://bugzilla.redhat.com/show_bug.cgi?id=2301667 Mohammed Isam <mohammed_isam1984@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pete@xxxxxxxxxxxx, | |psabata@xxxxxxxxxx, | |sanjay.ankur@xxxxxxxxx Flags| |needinfo?(pete@xxxxxxxxxxxx | |) | |needinfo?(psabata@xxxxxxxxx | |m) | |needinfo?(sanjay.ankur@gmai | |l.com) | |needinfo?(mikel@olasagasti. | |info) | |needinfo?(package-review@li | |sts.fedoraproject.org) --- Comment #4 from Mohammed Isam <mohammed_isam1984@xxxxxxxxx> --- (In reply to Mohammed Isam from comment #3) > (In reply to Mikel Olasagasti Uranga from comment #1) > > A few suggestions: > > > > > Group: System Environment/Libraries > > > > Not required > > > > > License: GPLv3+ > > > > Use SPDX short identifier: GPL-3.0-or-later > > > > > BuildRequires: make > > > > ^ add BR on make > > > > > make %{?_smp_mflags} > > > > You can use %make_build without %{?_smp_mflags} > > > > > make install > > > > Same, use %make_install macro > > > > > %{_bindir}/* > > > > Don't use wildcard, specify what binaries will be packaged. > > > > > %{_mandir}/man1/* > > > > Change to %{_mandir}/man1/FILE.X*, for example: > > > > %{_mandir}/man1/gnudos.1* > > > > > %{_libdir}/libgnudos.so.2 > > > %{_libdir}/libgnudos.so.2.0.0 > > > > Create a libs package with these. > > Hi Mikel, > > Thanks for your feedback. I have applied the suggested changes to the spec > file. > I have completed another Koji build as well: > https://koji.fedoraproject.org/koji/taskinfo?taskID=121517541 > > Thanks Dear reviewers, Could someone please review my package as the ticket has been raised a while back. This is a retired package that I would like to restore and continue to maintain on Fedora. Many thanks! @psabata@xxxxxxxxxx @sanjay.ankur@xxxxxxxxx -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2301667 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202301667%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
