https://bugzilla.redhat.com/show_bug.cgi?id=2332550 --- Comment #23 from Uri Lublin <uril@xxxxxxxxxx> --- (In reply to Fabio Valentini from comment #19) > I would also recommend to set the packaged commit in a macro like here: > > https://src.fedoraproject.org/rpms/wingpanel/blob/rawhide/f/wingpanel. > spec#_3-5 > > The SourceURL is also not in the recommended format for GitHub commit > snapshot archives, which should be: > > https://github.com/OWNER/PROJECT/archive/%{commit}/%{name}-%{shortcommit}. > tar.gz > > c.f. > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > #_commit_revision > > Right now you need to update the commit hash in multiple places in the spec > file (*and* in rust2rpm.toml) when making an update. Putting this into a > macro would mean you only need to update *one* line in the spec file. I'll add it in the spec file and change Source URL too. Thanks ! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2332550 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202332550%23c23 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
