https://bugzilla.redhat.com/show_bug.cgi?id=2332550 --- Comment #17 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Note that using a rust2rpm.toml config file is usually not necessary for packages like this, since they don't need to be regenerated with rust2rpm for every new upstream version. It doesn't *hurt*, but it's also not as helpful for non-crate packages as it is for crates. > License: ( ( MIT OR Apache-2.0 ) AND Unicode-DFS-2016 ) AND Apache-2.0 AND ( Apache-2.0 OR BSL-1.0 ) AND ( Apache-2.0 OR ISC OR MIT ) AND ( Apache-2.0 OR MIT ) AND ( BSD-2-Clause OR Apache-2.0 OR MIT ) AND MIT AND ( MIT OR Apache-2.0 ) AND ( MIT OR Apache-2.0 OR Zlib ) AND MPL-2.0 AND ( Unlicense OR MIT ) AND ( Zlib OR Apache-2.0 OR MIT ) > # LICENSE.dependencies contains a full license breakdown This is also more verbose than it needs to be. While mechanically applying the `" AND ".join(clause) for license in licenses` "algorithm" for getting this string is "technically not wrong", it contains duplicates and unnecessary parentheses. According to Red Hat Legal, the AND and OR operators in SPDX are associative and commutative, so this could be simplified to: """ License: Apache-2.0 AND MIT AND MPL-2.0 AND Unicode-DFS-2016 AND (Apache-2.0 OR BSL-1.0) AND (Apache-2.0 OR ISC OR MIT) AND (Apache-2.0 OR MIT) AND (BSD-2-Clause OR Apache-2.0 OR MIT) AND (MIT OR Apache-2.0 OR Zlib) AND (Unlicense OR MIT) """ Note that it's also unusual to put additional whitespace around "(" and ")", I've never seen SPDX expressions written like that. I don't know if that would be *wrong*, but it looks odd. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2332550 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202332550%23c17 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
