https://bugzilla.redhat.com/show_bug.cgi?id=2329411 --- Comment #10 from Stefano Brivio <sbrivio@xxxxxxxxxx> --- (In reply to Fabio Valentini from comment #6) > Taking this review. > > ============================================================ > > Some issues: > > 1. The SRPM and spec file don't match, please make sure to always upload / > link the new versions of both files when making changes. Oops. Uploaded both now. > 2. Mixed usage of spaces + tabs. TL;DR: Don't use tabs for indenting - > rust2rpm defaults to spaces. Sorry, I'm a right-minded C programmer with strong moral values. Fixed. > 3. Don't point Source URLs at files from branches - these links are not > stable. Point at a specific tag, if possible - if upstream does not tag > releases in git, point at the commit that matches the packaged version. > > 4. The Source URL for the LICENSE file is wrong. It points at a view of the > LICENSE file in the GitHub UI (i.e. an HTML page). Replace "/blob/" with > "/raw/" to get a URL that points at the actual raw file contents. > > 5. Please ask upstream to release a new version of the neli-proc-macros > crate. It looks like they made a change to include the LICENSE file (here: > https://github.com/jbaublitz/neli/commit/e67aede) but never actually > published a version with this change. There's a new version now, so I could actually fix these three points by simply re-running rust2rpm. I just needed a small tweak to avoid a "File listed twice" warning (https://github.com/rpm-software-management/rpm/issues/336). > 6. This project still uses version 1 of the "syn" crate. This version has > been obsolete for almost two years at this point, and it will likely fail to > parse Rust code that is valid syntax in future Rust versions. Please poke > upstream project to port to "syn" v2. In most cases, this should be easy and > require little to no code changes. That happened at https://github.com/jbaublitz/neli/pull/256, and I bumped the version in the spec file. Spec URL: https://passt.top/static/rust-neli-proc-macros.spec SRPM URL: https://passt.top/static/rust-neli-proc-macros-0.2.0~rc3-1.fc42.src.rpm Description: Procedural macros for neli Fedora Account System Username: sbrivio -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2329411 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202329411%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
