https://bugzilla.redhat.com/show_bug.cgi?id=2331669 --- Comment #30 from Jan Staněk <jstanek@xxxxxxxxxx> --- Oh the joys of updated gcc… the build now fails with few incompatible type errors: > format.c: In function ‘engformat’: > format.c:571:21: warning: conflicting types for built-in function ‘pow’; expected ‘double(double, double)’ [-Wbuiltin-declaration-mismatch] > 571 | double engmant, pow(), engabs, engexp; > | ^~~ > format.c:133:1: note: ‘pow’ is declared in header ‘<math.h>’ > 132 | #include "xmalloc.h" > +++ |+#include <math.h> > 133 | > format.c:604:31: error: too many arguments to function ‘pow’; expected 0, have 2 > 604 | engmant = val/pow(10.0e0, engexp); > | ^~~ ~~~~~~ > format.c:571:21: note: declared here > 571 | double engmant, pow(), engabs, engexp; > | ^~~ > file.c: In function ‘handle_backup’: > file.c:2091:62: error: passing argument 3 of ‘pthread_create’ from incompatible pointer type [-Wincompatible-pointer-types] > 2091 | pthread_exists = (pthread_create(&fthread, NULL, do_autobackup, NULL) == 0) ? 1 : 0; > | ^~~~~~~~~~~~~ > | | > | void * (*)(void) > In file included from file.c:87: > /usr/include/pthread.h:204:36: note: expected ‘void * (*)(void *)’ but argument is of type ‘void * (*)(void)’ > 204 | void *(*__start_routine) (void *), > | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ > file.c:2033:8: note: ‘do_autobackup’ declared here > 2033 | void * do_autobackup() { > | ^~~~~~~~~~~~~ Should be a matter of 1) using the proper math.h header instead of the ad-hoc definition, and 2) adding a unused void* argument to the `do_autobackup` function. Ideally open a PR with the changes to upstream, but don't hold your breath waiting for it to be accepted – feel free to add the changes as a patch to the spec/srpm. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2331669 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202331669%23c30 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
