https://bugzilla.redhat.com/show_bug.cgi?id=2338087 Paul Wouters <paul.wouters@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Paul Wouters <paul.wouters@xxxxxxxx> --- PACKAGE APPROVED with the below minor fixups Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Note: The pytest7 dependency is a false positive. It uses the latest pytest when built in rawhide The spec file in the rhbz was updated for the %license tag, but the spec file inside the src.rpm was not. Please ensure when adding the package to fedora to import using an updated src.rpm Fix typo: bingings -> bindings (twice) Maybe talk to upstream about all /usr/bin/env calls on library files, eg: E: non-executable-script /usr/lib/python3.13/site-packages/avro/__init__.py 644 /usr/bin/env python3 I guess ideally those should be removed and anything meant to be an executable should be placed in /usr/bin/, but other than filing an upstream bug, nothing needs to be done now. Issues: ======= - Package must not depend on deprecated() packages. Note: python3-pytest7 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License 2.0", "Unknown or generated", "Apache License 2.0", "SIL Open Font License 1.1", "MIT License", "Apache License 2.0 and/or Public domain", "*No copyright* Mozilla Public License 2.0", "Apache License 2.0 and/or BSD 3-Clause License", "BSD 3-Clause License". 369 files have unknown license. Detailed output of licensecheck in /tmp/2338087-python-avro/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages, /usr/lib/python3.13 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 7969 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. Note: patch name is self documenting (disable online tests) for which no upstream bug can be filed. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-avro-1.12.0-1.fc42.noarch.rpm python-avro-1.12.0-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpcghh3zal')] checks: 32, packages: 2 python-avro.src: E: spelling-error ('bingings', "%description -l en_US bingings -> bindings, ringings, Bunin's") python3-avro.noarch: E: spelling-error ('bingings', "%description -l en_US bingings -> bindings, ringings, Bunin's") python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/__init__.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/__main__.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/codecs.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/compatibility.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/constants.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/datafile.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/errors.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/io.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/ipc.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/name.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/protocol.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/schema.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/__init__.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/gen_interop_data.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/mock_tether_parent.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/sample_http_client.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/sample_http_server.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_bench.py 644 /usr/bin/env python python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_compatibility.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_datafile.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_datafile_interop.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_init.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_io.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_ipc.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_name.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_protocol.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_schema.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_script.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_tether_task.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_tether_task_runner.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_tether_word_count.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/word_count_task.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/tether/__init__.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/tether/tether_task.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/tether/tether_task_runner.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/tether/util.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/timezones.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/tool.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/utils.py 644 /usr/bin/env python3 python3-avro.noarch: W: no-manual-page-for-binary avro python3-avro.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/avro/LICENSE /usr/lib/python3.13/site-packages/avro-1.12.0.dist-info/LICENSE python-avro.src: E: description-line-too-long Apache Avro is a data serialization system. This package is Python bingings for Apache Avro. python3-avro.noarch: E: description-line-too-long Apache Avro is a data serialization system. This package is Python bingings for Apache Avro. 2 packages and 0 specfiles checked; 43 errors, 2 warnings, 7 filtered, 43 badness; has taken 0.8 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-avro.noarch: E: spelling-error ('bingings', '%description -l en_US bingings -> ringings, bindings, beginnings') python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/__init__.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/__main__.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/codecs.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/compatibility.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/constants.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/datafile.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/errors.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/io.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/ipc.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/name.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/protocol.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/schema.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/__init__.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/gen_interop_data.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/mock_tether_parent.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/sample_http_client.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/sample_http_server.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_bench.py 644 /usr/bin/env python python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_compatibility.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_datafile.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_datafile_interop.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_init.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_io.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_ipc.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_name.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_protocol.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_schema.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_script.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_tether_task.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_tether_task_runner.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/test_tether_word_count.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/test/word_count_task.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/tether/__init__.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/tether/tether_task.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/tether/tether_task_runner.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/tether/util.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/timezones.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/tool.py 644 /usr/bin/env python3 python3-avro.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/avro/utils.py 644 /usr/bin/env python3 python3-avro.noarch: W: no-manual-page-for-binary avro python3-avro.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/avro/LICENSE /usr/lib/python3.13/site-packages/avro-1.12.0.dist-info/LICENSE python3-avro.noarch: E: description-line-too-long Apache Avro is a data serialization system. This package is Python bingings for Apache Avro. 1 packages and 0 specfiles checked; 41 errors, 2 warnings, 3 filtered, 41 badness; has taken 0.2 s Source checksums ---------------- https://github.com/apache/avro/archive/refs/tags/release-1.12.0.tar.gz : CHECKSUM(SHA256) this package : 51832f9c2e81fa95addb74be627dac27b4883ec2c8627ec8471d99cfea787555 CHECKSUM(SHA256) upstream package : 51832f9c2e81fa95addb74be627dac27b4883ec2c8627ec8471d99cfea787555 Requires -------- python3-avro (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) Provides -------- python3-avro: python-avro python3-avro python3.13-avro python3.13dist(avro) python3dist(avro) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2338087 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, Generic Disabled plugins: Java, R, PHP, Ocaml, Haskell, Perl, fonts, SugarActivity, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2338087 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202338087%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
