[Bug 2315554] Review Request: python-gql - GraphQL client for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2315554



--- Comment #6 from Hirotaka Wakabayashi <hiwkby@xxxxxxxxx> ---
Hi Steve, Thanks for the response.


> Spec URL: https://straylen.web.cern.ch/rpms/python-gql/python-gql.spec
> SRPM URL: https://straylen.web.cern.ch/rpms/python-gql/python-gql-3.5.0-1.fc42.src.rpm


Could you please check the files are latest? The spec files seem not to be
same.

```
Diff spec file in url and in SRPM
---------------------------------
--- /home/build/dev/fedora_packaging/python-gql.spec    2025-01-09
17:58:52.000000000 +0000
+++
/home/build/dev/fedora_packaging/review-python-gql/srpm-unpacked/python-gql.spec
   2024-09-29 00:00:00.000000000 +0000
@@ -21,14 +21,7 @@
 GQL architecture is inspired by React-Relay and Apollo-Client.

-%pyproject_extras_subpkg -n python3-gql aiohttp websockets requests httpx
botocore
-
 %package -n     python3-%{pypi_name}
 Summary:        GraphQL client for Python

-# Explicit requires for /usr/bin/gql-cli
-# Surely there is a macro to do something like?
-# Recommends:    python3dist(gql[aiohttp]) = 3.8 
-Recommends:     python3-gql+aiohttp = %{version}-%{release}
-
 %description -n python3-%{pypi_name}
 This is a GraphQL client for Python 3.7+. Plays nicely with graphene,
```

The upstream project lists the aiohttp package in the "extras_require" section, 
so using the "extras_subpkg" macro is a good idea. If an error occurs during    
normal operation on Fedora despite aiohttp being an extra, I suggest submitting 
a PR to move aiohttp to the "install_requires" section.  

As of timestamp, in my environment, the original timestamp of "gql/cli.py" is
```
$ tar -tvf review-python-gql/upstream/gql-3.5.0.tar.gz | grep "gql/cli.py"
-rw-r--r-- runner/docker 16695 2024-01-03 14:40 gql-3.5.0/gql/cli.py
```
on the other hand, the timestamp of installed "gql/cli.py" is
```
$ ls -l /usr/lib/python3.13/site-packages/gql/cli.py 
-rw-r--r-- 1 root root 16695 Jan 15 00:00
/usr/lib/python3.13/site-packages/gql/cli.py
```


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2315554

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202315554%23c6

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux