https://bugzilla.redhat.com/show_bug.cgi?id=2338150 --- Comment #2 from Daniel Berrangé <berrange@xxxxxxxxxx> --- Some background notes to for anyone reviewing * This package contains pre-built binaries which would ordinarily be disallowed by Fedora. The SGX architectural enclaves, however, are considered to be "firmware for SGX", and thus prebuilt binaries are being allowed under the "Firmware exception". This viewpoint was approved by FESCo in https://pagure.io/fesco/issue/3304 * There were many options for package naming choice. 'linux-sgx' was chosen as a prefix because that matches the upstream project name and source tarball name 'linux-sgx', and 'enclaves-prebuilt' appended, to distinguish this from a different 'linux-sgx' package that will be introduced in a different review ticket * The prebuilt_dcap_1.22-repacked.tar.gz tarball is NOT a match for prebuilt_dcap_1.22.tar.gz provided by upstream. Upstream tarball has had some content removed by since it contains other non-enclave prebuilt binaries we CAN NOT distribute in Fedora, and one enclave that is known to contain unapproved crypto. THis was automated by https://berrange.fedorapeople.org/review/linux-sgx-enclaves-prebuilt/repack.sh whic hwill be added to dist-git if this review is approved. * Don't be fooled by the enclave binary names having '.so', '.so.N' & '.so.N.Y' suffixes. These are not traditional Linux shared libraries. They are static linked archives processed by a custom loader and NOT linked to native applications. rpmlint does not know this though, and so will generate some false positive errors & warnings. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2338150 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202338150%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
