https://bugzilla.redhat.com/show_bug.cgi?id=2334930 --- Comment #8 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Examination of the source-file diff confirms that the issues from the original review are resolved in exactly the manner suggested. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU Lesser General Public License, Version 2.1", "*No copyright* GNU Lesser General Public License", "Unknown or generated", "GNU Lesser General Public License v2.1 or later". 4 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2334930-casilda/20250109/2334930-casilda/licensecheck.txt ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmplgl_ls0k')] checks: 32, packages: 3 casilda.src: E: spelling-error ('wlroots', '%description -l en_US wlroots -> roots') casilda.x86_64: E: spelling-error ('wlroots', '%description -l en_US wlroots -> roots') casilda-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 2 errors, 1 warnings, 24 filtered, 2 badness; has taken 0.4 s Rpmlint (debuginfo) ------------------- Checking: casilda-debuginfo-0.2.0-1.fc42.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpwgs285e5')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 casilda.x86_64: E: spelling-error ('wlroots', '%description -l en_US wlroots -> roots') casilda-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 1 errors, 1 warnings, 24 filtered, 1 badness; has taken 0.6 s Source checksums ---------------- https://gitlab.gnome.org/jpu/casilda/-/archive/0.2.0/casilda-0.2.0.tar.gz : CHECKSUM(SHA256) this package : 1c3e675bbc49db4d49ca0db865dfabd393edd7a48e1086e8b6fa179d5399d85f CHECKSUM(SHA256) upstream package : 1c3e675bbc49db4d49ca0db865dfabd393edd7a48e1086e8b6fa179d5399d85f Requires -------- casilda (rpmlib, GLIBC filtered): libX11-xcb.so.1()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-4.so.1()(64bit) libpixman-1.so.0()(64bit) libwayland-server.so.0()(64bit) libwlroots-0.18.so()(64bit) libxkbcommon-x11.so.0()(64bit) libxkbcommon-x11.so.0(V_0.5.0)(64bit) libxkbcommon.so.0()(64bit) libxkbcommon.so.0(V_0.5.0)(64bit) rtld(GNU_HASH) casilda-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config casilda(x86-64) libcasilda-0.1.so.0()(64bit) pkgconfig(gtk4) pkgconfig(wlroots-0.18) Provides -------- casilda: casilda casilda(x86-64) libcasilda-0.1.so.0()(64bit) casilda-devel: casilda-devel casilda-devel(x86-64) pkgconfig(casilda-0.1) Diff spec file in url and in SRPM --------------------------------- --- /home/ben/fedora/review/2334930-casilda/20250109/2334930-casilda/srpm/casilda.spec 2025-01-09 15:56:58.307955401 -0500 +++ /home/ben/fedora/review/2334930-casilda/20250109/2334930-casilda/srpm-unpacked/casilda.spec 2025-01-08 19:00:00.000000000 -0500 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.7.3) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + Name: casilda Version: 0.2.0 @@ -75,3 +85,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Thu Jan 09 2025 John Doe <packager@xxxxxxxxxxx> - 0.2.0-1 +- Uncommitted changes +## END: Generated by rpmautospec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2334930 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202334930%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
