https://bugzilla.redhat.com/show_bug.cgi?id=2336406 --- Comment #4 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- (In reply to wojnilowicz from comment #2) > 2 If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %license. > Note: License file COPYING is not marked as %license > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/LicensingGuidelines/#_license_text > > Could you link your PR at https://github.com/skellet0r/eth-stdlib/pull/21 > near the license tag? Done. > 3) You have duplicated license file. To fix, please remove the line > "%license COPYING.LESSER" and change the line "%pyproject_save_files eth > " to "%pyproject_save_files -l eth". More at > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_build_macros I'm afraid we cannpt do it now. A tool this project is using (poetry) is not yet PEP-0639 ready: * https://github.com/python-poetry/poetry/issues/9670 > [!]: Requires correct, justified where necessary. > > You have "BuildRequires: python3-pytest-cov" but according to > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters > "packages SHOULD NOT run “linters”: code style checkers, test coverage > checkers", so I believe your should not require this. > If pytest-cov runs nevertheless then maybe ".coveragerc" needs to be > removed. Done. > [!]: Patches link to upstream bugs/comments/lists or are otherwise > justified. > > Could you add a short comment justifying > python-eth-stdlib-0001-Switch-to-cryptodomex.patch? Done. Spec URL: https://peter.fedorapeople.org/packages/python-eth-stdlib.spec SRPM URL: https://peter.fedorapeople.org/packages/python-eth-stdlib-0.2.7-1.fc41.src.rpm Koji scratch build for Rawhide: * https://koji.fedoraproject.org/koji/taskinfo?taskID=127842448 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2336406 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202336406%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
