https://bugzilla.redhat.com/show_bug.cgi?id=2328743 --- Comment #10 from Jeremy Cline <jeremy@xxxxxxxxxx> --- > - A newer version, 1.1.0b2, is available. Yeah, as you suspect it's because of azure-cli's strict pinning. I keep thinking about having azure-cli bundle its dependencies so other SDK users aren't stuck on odd versions, but it's never been high enough on my list to investigate thoroughly. > Oh, one suggestion I missed in the original review feedback. The > pyproject-rpm-macros are already correctly marking as %license the license > file in the .dist-info directory via %{pyproject_files}, so you don’t have > to install a duplicate copy manually. > > $ rpm -qL -p > results/python3-azure-mgmt-postgresqlflexibleservers-1.1.0~b1-1.fc42.noarch. > rpm > > /usr/lib/python3.13/site-packages/azure_mgmt_postgresqlflexibleservers-1.1. > 0b1.dist-info/LICENSE > /usr/share/licenses/python3-azure-mgmt-postgresqlflexibleservers/LICENSE > > You can remove > > %license LICENSE > > and change > > %pyproject_save_files azure > > to > > %pyproject_save_files -l azure > > to “assert” that a license file was included in the %{pyproject_files}; this > guards against the license file “disappearing” in a future update, perhaps > by upstream switching to a build backend that no longer sets the PEP 639 > License-File field. Ah very nice, I wasn't aware of that! > Finally, as a very minor nitpick, you might consider removing “This package > has been tested with Python 3.8+.” from the description. Since people will > only be using RPM packages with the system Python interpreter and can assume > that it’s supported, it’s not really useful information. Yeah, makes sense. I'll address both during the package import (and on https://bugzilla.redhat.com/show_bug.cgi?id=2328742), thanks for the reviews! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2328743 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202328743%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
