https://bugzilla.redhat.com/show_bug.cgi?id=2337188 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > Source0: %{url}/archive/refs/tags/v%{version}.tar.gz This should be "%{url}/archive/v%{version}/%{name}-%{version}.tar.gz" > qmake6 QMAKE_CFLAGS+="%optflags" \ > QMAKE_CXXFLAGS+="%optflags" \ > QMAKE_STRIP="/bin/true" This should be replaced with the "%qmake_qt6" macro. > %make_install INSTALL_ROOT="%buildroot" You should use "%{buildroot}" here (with the curly braces) for consistency. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2337188 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202337188%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue