https://bugzilla.redhat.com/show_bug.cgi?id=2335652 --- Comment #3 from Jeremy Newton <alexjnewt@xxxxxxxxxxxx> --- Furthermore, you should add a rocm-llvm-filesystem package that owns the following, and have this package require it: /usr/lib64/rocm/llvm/lib/clang /usr/lib64/rocm/llvm/lib/cmake /usr/lib64/rocm/llvm/lib/clang/18/include /usr/lib64/rocm/llvm/include /usr/lib64/rocm/llvm/lib /usr/lib64/rocm/llvm/lib/clang/18 /usr/lib64/rocm/llvm /usr/lib64/rocm/llvm/bin If a user installs just rocm-omp, then uninstalls the package, it will orphan those directories. Having the filesystem package allows them to still have ownership, and dnf will auto clean up the leaf package. I noticed it complains of: Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rocm- omp-static But static actually requires devel which requires the base package. Anyway, false positive. Also you used defines here: Note: %define requiring justification: %define __sourcedir openmp, %define _vpath_srcdir openmp Not sure of the reason, but you need to comment it. Finally, not sure what this rpmlint output is about: rocm-omp-static.x86_64: E: static-library-without-symtab /usr/lib64/rocm/llvm/lib/libomptarget.devicertl.a rocm-omp-static.x86_64: E: static-library-without-debuginfo /usr/lib64/rocm/llvm/lib/libomptarget.devicertl.a rocm-omp-static.x86_64: E: lto-no-text-in-archive /usr/lib64/rocm/llvm/lib/libomptarget.devicertl.a rocm-omp-devel.x86_64: E: invalid-soname /usr/lib64/rocm/llvm/lib/libomp.so libomp.so -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2335652 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202335652%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
