[Bug 2316576] Review Request: sdl2-compat - SDL 2.0 runtime compatibility library using SDL 3.0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2316576



--- Comment #8 from Davide Cavalca <davide@xxxxxxxxxxxx> ---
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "zlib License", "Unknown or generated", "*No copyright* Public
     domain", "mit_whatever", "BSD 3-Clause License", "BSD 3-Clause License
     and/or mit_whatever", "*No copyright* SIL Open Font License 1.1",
     "Khronos License and/or zlib License", "MIT License and/or zlib
     License", "Khronos License and/or MIT License", "MIT License", "Apache
     License 2.0", "Khronos License", "zlib License [generated file]", "NTP
     License and/or zlib License". 140 files have unknown license. Detailed
     output of licensecheck in /tmp/review-sdl2-compat/licensecheck.txt

It looks like this bundles some sources of varied licenses, please double
check.

[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/include/SDL2(SDL2-devel), /usr/lib64/cmake/SDL2(SDL2-devel)

If this is meant to replace SDL2 it's probably fine

[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     sdl2-compat-devel , sdl2-compat-static

You do have this, so I'm not sure why it's triggering

[!]: %check is present and all tests pass.

Is there a test suite you can run?


sdl2-compat-devel.aarch64: E: static-library-without-debuginfo
/usr/lib64/libSDL2_test.a
sdl2-compat-devel.aarch64: E: static-library-without-debuginfo
/usr/lib64/libSDL2main.a
sdl2-compat-static.aarch64: E: static-library-without-debuginfo
/usr/lib64/libSDL2.a

Is the build system stripping the static libraries?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2316576

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202316576%23c8

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux