https://bugzilla.redhat.com/show_bug.cgi?id=2329763 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #8 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Comments: a) $rpmlint -e non-executable-script non-executable-script: This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. Examining $ more pykakasi-2.3.0-1.fc42.noarch.rpm/usr/bin/kakasi #! /usr/bin/python3 -sP # -*- coding: utf-8 -*- import re import sys from pykakasi.cli import cli_main if __name__ == '__main__': sys.argv[0] = re.sub(r'(-script\.pyw|\.exe)?$', '', sys.argv[0]) sys.exit(cli_main()) would remove the shebang line from cli.py b) Sphinx has an option to build man pages: https://www.sphinx-doc.org/en/master/usage/builders/index.html Perhaps add pushd docs sphinx-build . -b man -d man popd c) Pull request to update text: https://codeberg.org/miurahr/pykakasi/pulls/176 d) License warning is from https://codeberg.org/miurahr/pykakasi/src/branch/master/src/data/kakasidict.utf8 so can be ignored. e) Approved. Please fix (a) before importing. Consider adding man pages as documentation. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2329763 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202329763%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
