https://bugzilla.redhat.com/show_bug.cgi?id=2313237 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review? --- Comment #9 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Package looks almost good to me. The package.include setting in Cargo.toml is very strange though: I'm quite sure that `.gitignore` and `.travis.yml` should just be dropped from that list. `Cargo.toml` is always included in published crates, so there's no need to list it explicitly. And I'm a bit confused why the tests fail with missing files, when there's a lot of stuff in "assets" that *does* look like test data. Are the paths in test code just wrong? Can the "assets" directory be excluded from packaged files, if it's indeed just test input files? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2313237 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202313237%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
