Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libdstr - Dave's String class https://bugzilla.redhat.com/show_bug.cgi?id=431692 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From panemade@xxxxxxxxx 2008-02-06 11:37 EST ------- Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 3a35a29f33b22c04fe3d2ebe5dc29b5f libdstr-20080124.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package libdstr-20080124-1.fc9 -> Provides: libdstr.so.2Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libdstr.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) rtld(GNU_HASH) + Package libdstr-devel-20080124-1.fc9 -> Requires: libdstr.so.2 Not sure why Requires for libdstr-devel-20080124-1.fc9 is missing libdstr = 20080124-1.fc9 But when I did "rpmbuild -ba libdstr.spec" on my machine I see its showing that requires on main package. Am I missing something to look? Note:- I used build.log from your F9 scratch build for this review. But for F8 build I can see that Requires is present. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review