https://bugzilla.redhat.com/show_bug.cgi?id=2330455 --- Comment #9 from Jeremy Cline <jeremy@xxxxxxxxxx> --- Thanks, I think pretty much all my concerns were addressed. There's a few small things I noticed this time around: - rpmlint complains about two macros in "unexpected" places: there's one in the changelog ("- Fix %check.") and another inside a comment ("# Remove some bash scripts wrongly included in the license directory by %go_vendor_license_install"). It's a warning because RPM will expand those macros even you're probably not expecting them to and it may end up doing weird things (depending on the macro). I'd recommend just dropping the leading "%". - There's a few shell scripts amongst the licenses in /usr/share/licenses/golang-github-inspektor-gadget/vendor/k8s.io/code-generator/. Since this is all autogenerated I think it's okay to leave it and maybe separately see if the tools can catch this, or you can drop a `rm` or two in the install section. - Technically this is no longer the latest version. Given there's a release from yesterday, though, I think it's okay if you'd prefer to import this version and then update it, but if you want to bump it to 0.36 and get a re-review that's okay too. I'd like someone with Go expertise to review this, but if you can't find anyone let me know and I'll officially approve this. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2969600 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-inspektor-gadget-0.34.0-1.fc42.x86_64.rpm golang-github-inspektor-gadget-0.34.0-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp__u6gi8d')] checks: 32, packages: 2 golang-github-inspektor-gadget.src: E: spelling-error ('eBPF', 'Summary(en_US) eBPF -> Feb') golang-github-inspektor-gadget.src: E: spelling-error ('eBPF', '%description -l en_US eBPF -> Feb') golang-github-inspektor-gadget.src: E: spelling-error ('ig', '%description -l en_US ig -> if, i, g') golang-github-inspektor-gadget.x86_64: E: readelf-failed /usr/bin/ig 'utf-8' codec can't decode byte 0xc2 in position 11570: invalid continuation byte golang-github-inspektor-gadget.x86_64: E: non-executable-script /usr/share/licenses/golang-github-inspektor-gadget/vendor/k8s.io/code-generator/generate-groups.sh 644 /usr/bin/env bash golang-github-inspektor-gadget.x86_64: E: non-executable-script /usr/share/licenses/golang-github-inspektor-gadget/vendor/k8s.io/code-generator/generate-internal-groups.sh 644 /usr/bin/env bash golang-github-inspektor-gadget.x86_64: E: non-executable-script /usr/share/licenses/golang-github-inspektor-gadget/vendor/k8s.io/code-generator/kube_codegen.sh 644 /usr/bin/env bash golang-github-inspektor-gadget.x86_64: W: no-manual-page-for-binary ig golang-github-inspektor-gadget.x86_64: W: no-documentation golang-github-inspektor-gadget.spec:51: W: macro-in-comment %go_vendor_license_install golang-github-inspektor-gadget.spec:130: W: macro-in-%changelog %check golang-github-inspektor-gadget.spec: W: invalid-url Source1: inspektor-gadget-0.34.0-vendor.tar.xz golang-github-inspektor-gadget.x86_64: E: files-duplicated-waste 1073108 golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/sigs.k8s.io/security-profiles-operator/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/AdaLogics/go-fuzz-headers/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/AdamKorcz/go-118-fuzz-build/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/containerd/cgroups/v3/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/containerd/fifo/LICENSE:(and 19 more) golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/k8s.io/utils/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/Masterminds/goutils/LICENSE.txt:/usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/go-jose/go-jose/v4/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/go-openapi/jsonpointer/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/go-openapi/jsonreference/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/go-openapi/swag/LICENSE:(and 25 more) golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/blang/semver/v4/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/blang/semver/LICENSE golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/klauspost/compress/zstd/internal/xxhash/LICENSE.txt /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/cespare/xxhash/v2/LICENSE.txt golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/containerd/typeurl/v2/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/containerd/containerd/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/containerd/containerd/api/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/containerd/continuity/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/containerd/errdefs/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/containerd/log/LICENSE:(and 1 more) golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/sigs.k8s.io/yaml/goyaml.v2/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/containers/common/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/go-logr/logr/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/go-logr/zapr/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/opencontainers/selinux/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/gopkg.in/yaml.v2/LICENSE:(and 6 more) golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/containers/ocicrypt/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/containers/image/v5/LICENSE golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/k8s.io/klog/v2/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/coreos/go-systemd/v22/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/golang/groupcache/LICENSE golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/docker/distribution/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/distribution/reference/LICENSE golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/moby/moby/AUTHORS /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/docker/docker/AUTHORS golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/moby/term/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/docker/docker/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/moby/moby/LICENSE golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/moby/moby/NOTICE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/docker/docker/NOTICE golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/docker/go-units/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/docker/go-connections/LICENSE golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/gopkg.in/evanphx/json-patch.v4/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/evanphx/json-patch/v5/LICENSE golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/k8s.io/utils/internal/third_party/forked/golang/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/go-jose/go-jose/v4/json/LICENSE golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/go.opencensus.io/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/google/go-containerregistry/LICENSE golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/hashicorp/hcl/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/hashicorp/errwrap/LICENSE golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/kr/text/License /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/kr/pretty/License golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/k8s.io/code-generator/third_party/forked/golang/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/liggitt/tabwriter/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/sagikazarmark/slog-shim/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/k8s.io/apimachinery/third_party/forked/golang/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/k8s.io/client-go/third_party/forked/golang/LICENSE golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/mitchellh/reflectwalk/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/mitchellh/mapstructure/LICENSE golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/onsi/gomega/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/onsi/ginkgo/LICENSE golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/google.golang.org/protobuf/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/rogpeppe/go-internal/LICENSE golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/spf13/cobra/LICENSE.txt /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/spf13/afero/LICENSE.txt golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/spf13/viper/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/spf13/cast/LICENSE golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/vishvananda/netns/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/github.com/vishvananda/netlink/LICENSE golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/google.golang.org/grpc/AUTHORS /usr/share/licenses/golang-github-inspektor-gadget/vendor/go.opencensus.io/AUTHORS golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/golang.org/x/tools/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/golang.org/x/crypto/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/golang.org/x/exp/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/golang.org/x/mod/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/golang.org/x/net/LICENSE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/golang.org/x/oauth2/LICENSE:(and 5 more) golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/k8s.io/utils/internal/third_party/forked/golang/PATENTS /usr/share/licenses/golang-github-inspektor-gadget/vendor/golang.org/x/crypto/PATENTS:/usr/share/licenses/golang-github-inspektor-gadget/vendor/golang.org/x/exp/PATENTS:/usr/share/licenses/golang-github-inspektor-gadget/vendor/golang.org/x/mod/PATENTS:/usr/share/licenses/golang-github-inspektor-gadget/vendor/golang.org/x/net/PATENTS:/usr/share/licenses/golang-github-inspektor-gadget/vendor/golang.org/x/sync/PATENTS:(and 9 more) golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/sigs.k8s.io/yaml/goyaml.v3/NOTICE /usr/share/licenses/golang-github-inspektor-gadget/vendor/gopkg.in/yaml.v2/NOTICE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/gopkg.in/yaml.v3/NOTICE:/usr/share/licenses/golang-github-inspektor-gadget/vendor/sigs.k8s.io/yaml/goyaml.v2/NOTICE golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/sigs.k8s.io/yaml/goyaml.v3/LICENSE /usr/share/licenses/golang-github-inspektor-gadget/vendor/gopkg.in/yaml.v3/LICENSE golang-github-inspektor-gadget.x86_64: W: files-duplicate /usr/share/licenses/golang-github-inspektor-gadget/vendor/k8s.io/code-generator/generate-internal-groups.sh /usr/share/licenses/golang-github-inspektor-gadget/vendor/k8s.io/code-generator/generate-groups.sh 2 packages and 0 specfiles checked; 8 errors, 36 warnings, 7 filtered, 8 badness; has taken 4.0 s Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/inspektor-gadget/inspektor-gadget/archive/v0.34.0/inspektor-gadget-0.34.0.tar.gz : CHECKSUM(SHA256) this package : 296a7c01f9b302b9c070fa1f9645bbbc3b4ad69202357c1d691b39db685bd4da CHECKSUM(SHA256) upstream package : 296a7c01f9b302b9c070fa1f9645bbbc3b4ad69202357c1d691b39db685bd4da Requires -------- golang-github-inspektor-gadget (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH) Provides -------- golang-github-inspektor-gadget: golang-github-inspektor-gadget golang-github-inspektor-gadget(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2330455 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: PHP, fonts, SugarActivity, Python, Haskell, Java, Ocaml, Perl, C/C++, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2330455 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202330455%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
