Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: pygtk2 (stalled) https://bugzilla.redhat.com/show_bug.cgi?id=226333 ------- Additional Comments From tim.lauridsen@xxxxxxxxxxxxxx 2008-02-06 09:05 EST ------- MUST: * Package is matching naming guidelines. * spec file in named %{name}.spec * it is legal for Fedora to distribute this * license field matches the actual license. * license is open source-compatible have the right good license shortname : LGPLv2+ * License file must be in %doc (it it exists) * Spec file is written in American English * Spec file is legible. * Sources match upstream. MD5SUM: a816346d750d61e3fa67a200e4292694 http://ftp.gnome.org/pub/GNOME/sources/pygtk/2.12/pygtk-2.12.1.tar.bz2 a816346d750d61e3fa67a200e4292694 pygtk-2.12.1.tar.bz2 * summary and description fine * correct buildroot * %{?dist} is used * license text included in package and marked with %doc * package meets FHS (http://www.pathname.com/fhs/) * changelog format fine * Packager/Vendor/Distribution/Copyright tags not used * Summary tag does not end in a period * Package compiles and build into RPM's on : i386 etc. * no Exclude Arch * BuildRequires for all build requerements (- the ones on the Exception list) * no locales * no shared libs * Package own all created directories. * No duplicate files in %files * Every %files section includes a %defattr(...) line * Package has a %clean with a rm -rf %{buildroot} or $RPM_BUILD_ROOT * consistently use of macros * Package contains code or or permissable content. * Large documentation files goes into -doc subpackage. * files in %doc dont affect runtime. * header files goes into -devel subpackage * no static libs * package has pkgconfig (.pc) files and has a 'Requires: pkgconfig' * -devel subpackage has a 'Requires: %{name} = %{version}-%{release}' * *.la libtool archives are removed in spec (if available) * not a gui application * package don't own files and dirs owned by other packages. * %install starts with an rm -rf %{buildroot} * rpm package filenames is in valid UTF-8. * no Rpath * no config files * no init scripts * no %makeinstall used * no Requires(pre,post) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review