https://bugzilla.redhat.com/show_bug.cgi?id=2290548 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |quantum.analyst@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #3 from Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> --- > Summary: Polygon clipping library v2 Upstream calls it "Polygon Clipping and Offsetting Library" > Source0: https://github.com/AngusJohnson/Clipper2/archive/refs/tags/Clipper2_%{version}.tar.gz > Patch0: clipper2-removegtest.patch > Patch1: clipper2-compile.patch Should change to unnumbered Source/Patch. > pushd CPP > %cmake > %check > pushd CPP > %if 0%{?fedora} > pushd redhat-linux-build > %endif Instead you should set _vpath_srcdir to CPP so you can call the %cmake macros like normal, and then use %_vpath_builddir instead of hardcoding the build directory. https://docs.fedoraproject.org/en-US/packaging-guidelines/vpath/ > %{_libdir}/libClipper2.so.* > %{_libdir}/libClipper2Z.so.* Library globs should not be used https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2290548 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202290548%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
