https://bugzilla.redhat.com/show_bug.cgi?id=2324137 --- Comment #3 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- (In reply to wojnilowicz from comment #2) > LGTM, although I think that you should justify with comments a bit more why > you use those patches. I guess that: > Patch1: python-eth_keyfile-0001-Fedora-use-cryptodome-explicitly.patch > Patch2: python-eth_keyfile-0002-Relax-dependencies.patch > are used because pycryptodomex is a newer pycryptodome from the same author > and the later one should be used only in legacy cases, while > Patch3: python-eth_keyfile-0003-Add-fixtures-back.patch > is a minimal testset for pytest not to fail. Yes, exactly. I'll add comments to spec-file before uploading. Thank you for reviewing this! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2324137 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324137%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
